Fix downloading of Mbed 2 when zip is too big #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Mbed 2 zip was being downloaded into memory. This downloads the zip in 1 MB chunks then writes them to disk to avoid running out of memory.
screamerbg
previously approved these changes
Feb 23, 2019
theotherjimmy
previously approved these changes
Feb 23, 2019
Contributor
theotherjimmy
left a comment
theotherjimmy
left a comment
There was a problem hiding this comment.
I like the code style improvement too!
Co-Authored-By: bridadan <[email protected]>
theotherjimmy
approved these changes
Mar 4, 2019
Contributor
|
I was not planning on creating a release for this. @bridadan @screamerbg Do we need to release this now? |
theotherjimmy
added a commit
to theotherjimmy/mbed-cli
that referenced
this pull request
Mar 4, 2019
**Fixed:** * ARMmbed#850 Don't overwrite `mbed_app.json` on newly imported projects * ARMmbed#857 Stream downloads of mbed 2 zip files. Prevents Out of memory(OOM) errors
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mbed 2 zip was being downloaded into memory. With the latest releases, my Windows machine failed to download it because it ran out of memory! This downloads the zip in 1 MB chunks then writes them to disk to avoid running out of memory.