Skip to content

Conversation

@rbgodwin
Copy link
Contributor

Add in checks for SMPTE2110-22

@rbgodwin
Copy link
Contributor Author

Changes:

Addition of specific tests for SMPTE2110-22 in new test sections
Verbose printout of results for passed tests as well as failed
Refactoring of tests common to SMPTE2110-20 and 22
Updates to README
Update to example file for SMPTE-2110-22 SDP file
Addition of --smpte2110_22 parameter to sdpoker

Test Method

  • Turn on --verbose and check tests pass for " node sdpoker.js --smpte2110_22 examples/st2110-22.sdp --should --verbose "
  • Edit st2110-22.sdp to change value to force failure (e.g. b=BS:216000) and rerun to get error for the bandwidth test:
TEST Passed: Test ST2110-10 Section 8.1 Test 1 - Shall have media-level mediaclk per stream
TEST Passed: Test ST2110-10 Section 8.1 Test 2 - Should have mediaclk using direct reference
TEST Passed: Test ST2110-10 Section 8.1 Test 1 - Shall have a media-level ts-refclk
TEST Passed: Test ST2110-10 Section 8.2 Test 2 - Reference clocks shall be ptp reference or shall be localmac
TEST Passed: Test ST2110-10 Section 8.2 Test 3 - PTP ts-refclk parameters all good.
TEST Passed: Test ST2110-10 Section 8.2 Test 4 - If local mac clock, check MAC address.
TEST Skipped: Test ST2110-10 Section 8.3 Test 1 - Use --duplicate to check 
Test Skipped: Test ST2110-10 Section 8.3 Test 3 - Separate destination addresses. No a=group present.
Test Skipped: Test ST 2110-22 Section 5.3 Test 1- TP parameter is acceptable value. Use --shaping to test.
Test Passed: Test ST2110-22 Section 6. Test 1 - All video streams have rtpmap entry jxsv/90000
Test Passed: Test ST 2110-10 Section 62 Test 1 - Video parameters present and all good.
Test Passed: Test ST2110-22 Section 7.1 Test 1 - Conforms to SMPTE-2110-10 for video media specification
Test Passed: Test ST2110-22 Section 7.2 Test 1 - All required parameters are present
Test Passed: Test ST 2110-22 Section 74 -  Check for framerate specified
Found 1 error(s) in SDP file:
1: Line 7: In 'b=<bwtype>:<bandwidth>' bwtype must be 'AS' as per SMPTE ST2110-22 Section 7.3.```

@garethsb
Copy link
Contributor

After this is merged, we need to tag as v0.3.0 and make a tag for the 'release'.

Copy link

@peterbrightwell peterbrightwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

Copy link
Contributor

@garethsb garethsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Really great improvements, @rbgodwin-nt !

@garethsb garethsb merged commit 0304d22 into master Feb 21, 2023
@garethsb garethsb deleted the bcp-006-01-rbg branch February 21, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants