ParticleContainer: Split #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+327
to
+338
| // ParticleTileType& DefineAndReturnParticleTile (int lev, int grid, int tile) | ||
| // { | ||
| // m_particles[lev][std::make_pair(grid, tile)].define(NumRuntimeRealComps(), NumRuntimeIntComps()); | ||
| // return ParticlesAt(lev, grid, tile); | ||
| // } | ||
| // template <class Iterator> | ||
| // ParticleTileType& DefineAndReturnParticleTile (int lev, const Iterator& iter) | ||
| // { | ||
| // auto index = std::make_pair(iter.index(), iter.LocalTileIndex()); | ||
| // m_particles[lev][index].define(NumRuntimeRealComps(), NumRuntimeIntComps()); | ||
| // return ParticlesAt(lev, iter); | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code
| // const Vector<std::string>& int_comp_names) const; | ||
| // void WritePlotFilePre (); | ||
|
|
||
| // void WritePlotFilePost (); |
Check notice
Code scanning / CodeQL
Commented-out code
| // Long NumberOfParticlesAtLevel (int level, bool only_valid = true, bool only_local = false) const; | ||
| .def("NumberOfParticlesAtLevel", &ParticleContainerType::NumberOfParticlesAtLevel, | ||
| py::arg("level"), py::arg("only_valid")=true, py::arg("only_local")=false) | ||
| // Vector<Long> NumberOfParticlesInGrid (int level, bool only_valid = true, bool only_local = false) const; |
Check notice
Code scanning / CodeQL
Commented-out code
| .def("ByteSpread",&ParticleContainerType::ByteSpread) | ||
| .def("PrintCapacity", &ParticleContainerType::PrintCapacity) | ||
| .def("ShrinkToFit", &ParticleContainerType::ShrinkToFit) | ||
| // Long NumberOfParticlesAtLevel (int level, bool only_valid = true, bool only_local = false) const; |
Check notice
Code scanning / CodeQL
Commented-out code
| // void InitFromAsciiFile (const std::string& file, int extradata, | ||
| // const IntVect* Nrep = nullptr); | ||
|
|
||
| // void InitFromBinaryFile (const std::string& file, int extradata); |
Check notice
Code scanning / CodeQL
Commented-out code
Comment on lines
+164
to
+165
| // ParticleContainer ( ParticleContainer && ) = default; | ||
| // ParticleContainer& operator= ( ParticleContainer && ) = default; |
Check notice
Code scanning / CodeQL
Commented-out code
Comment on lines
+161
to
+162
| // ParticleContainer ( const ParticleContainer &) = delete; | ||
| // ParticleContainer& operator= ( const ParticleContainer & ) = delete; |
Check notice
Code scanning / CodeQL
Commented-out code
| >; | ||
| using ParticleInitData = typename ParticleContainerType::ParticleInitData; | ||
| using ParticleTileType = typename ParticleContainerType::ParticleTileType; | ||
| //using AoS = typename ParticleContainerType::AoS; |
Check notice
Code scanning / CodeQL
Commented-out code
Split specializations for faster, more resource efficient compiles that can be parallelized.
ax3l
commented
Feb 11, 2023
ax3l
commented
Feb 11, 2023
ax3l
commented
Feb 11, 2023
ax3l
commented
Feb 11, 2023
ax3l
commented
Feb 11, 2023
This was referenced Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split specializations for faster, more resource efficient compiles that can be parallelized.