feat: jax analysis reporting command line tool#210
Merged
Conversation
Collaborator
|
The API looks good to me |
Collaborator
|
@jiagaoxiang can you give this a try as well for your usecase? |
gabeweisz
reviewed
Jun 30, 2025
TraceLens/TreePerf/jax_analyses.py
Outdated
|
|
||
| @staticmethod | ||
| def create_breakdown_df(events: dict, total_time): | ||
| def create_breakdown_df(events: dict, total_time, num_gpus: int): |
Collaborator
There was a problem hiding this comment.
Can you add a default here? Or detect the # of GPUs from the trace? Otherwise this might break existing code
There was a problem hiding this comment.
@gabeweisz can you review the PR again with Juha's changes?
- When profiling a jit-compiled function like the train_step in Maxtext, the parsed xplane.pb will have a header line starting with "HloModule ". This line has no information that we currently want to parse but at the same time, it causes an exception to be raised. This commit completely ignores the header line.
This reverts commit 1ececf7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Add jax analysis reporting command line tool with console scripts entry point
-Add number of gpus normalized time to create_breakdown_df