Skip to content

Feat/perf report compare#193

Merged
ajassani merged 4 commits intomainfrom
feat/perf_report_compare
Jun 7, 2025
Merged

Feat/perf report compare#193
ajassani merged 4 commits intomainfrom
feat/perf_report_compare

Conversation

@ajassani
Copy link
Copy Markdown
Collaborator

@ajassani ajassani commented Jun 7, 2025

No description provided.

@ajassani ajassani requested a review from Copilot June 7, 2025 19:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new user guide for comparing TraceLens performance reports and refactors tensor-type detection logic in the performance model.

  • Add examples/compare_perf_reports.md with step-by-step instructions and tables for comparing .xlsx reports.
  • Remove the is_tensortype helper in TraceLens/PerfModel/perf_model.py and replace it with shape-based checks.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
examples/compare_perf_reports.md New markdown guide detailing inputs, flags, output, and design.
TraceLens/PerfModel/perf_model.py Remove is_tensortype; use shape_in* != () for tensor checks.

Comment on lines +992 to +993
in1_is_tensor = self.param_details['shape_in1'] != ()
in2_is_tensor = self.param_details['shape_in2'] != ()
Copy link

Copilot AI Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original is_tensortype check also verified the data type; switching to shape-only may misclassify non-floating tensors (e.g., integer tensors) as 'tensor types'. Consider reintroducing a dtype check or renaming this logic to accurately reflect its new semantics.

Suggested change
in1_is_tensor = self.param_details['shape_in1'] != ()
in2_is_tensor = self.param_details['shape_in2'] != ()
in1_is_tensor = self.param_details['shape_in1'] != () and name2bpe(self.param_details['dtype_in1_in2_out'][0]) is not None
in2_is_tensor = self.param_details['shape_in2'] != () and name2bpe(self.param_details['dtype_in1_in2_out'][1]) is not None

Copilot uses AI. Check for mistakes.

---

### 1 . What It Takes In
Copy link

Copilot AI Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] There is an extra space before the period in the section header. For consistency, change ### 1 . What It Takes In to ### 1. What It Takes In.

Suggested change
### 1 . What It Takes In
### 1. What It Takes In

Copilot uses AI. Check for mistakes.
@ajassani ajassani merged commit 0ee77dd into main Jun 7, 2025
@ajassani ajassani deleted the feat/perf_report_compare branch June 7, 2025 19:12
lauri9 pushed a commit that referenced this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants