Merged
Conversation
:wq Merge branch 'main' of https://github.com/AMD-AIG-AIMA/TraceLens
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the torch import issue by introducing a lazy-loading helper for PyTorch and updating type annotations accordingly. Key changes include:
- Introducing the _get_torch_or_raise() function for dynamically importing torch.
- Updating type annotations to use string literals for torch Tensor and FunctionSchema types.
- Removing direct torch imports from other modules in favor of lazy loading.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TraceLens/EventReplay/utils.py | Added _get_torch_or_raise() for lazy torch imports and updated type hints |
| TraceLens/EventReplay/event_replay.py | Replaced direct torch import with lazy import using _get_torch_or_raise() and updated type annotations |
| TraceLens/EventReplay/batched_replay.py | Removed torch import and updated utils imports accordingly |
Comments suppressed due to low confidence (1)
TraceLens/EventReplay/utils.py:4
- The global variable _torch_module is accessed without concurrency protection. Consider adding a locking mechanism to avoid potential race conditions if this code is used in a multi-threaded environment.
_torch_module = None
lauri9
pushed a commit
that referenced
this pull request
Jun 11, 2025
require torch only for event replay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.