Skip to content

Feat/qkv stride #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajassani merged 6 commits into from
May 15, 2025
Merged

Feat/qkv stride #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
369ef65
fix flash true in fusedattnfunc
ajassani May 12, 2025
05ee1a1
Merge branch 'main' of https://github.com/AMD-AIG-AIMA/TraceLens
ajassani May 13, 2025
1eb0d44
Merge branch 'main' of https://github.com/AMD-AIG-AIMA/TraceLens
ajassani May 13, 2025
c891c2c
Merge branch 'main' of https://github.com/AMD-AIG-AIMA/TraceLens
ajassani May 14, 2025
0d77dbd
Merge branch 'main' of https://github.com/AMD-AIG-AIMA/TraceLens
ajassani May 15, 2025
5de6a45
include q k v stride
ajassani May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion TraceLens/PerfModel/perf_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,13 +844,17 @@ class flash_attention(SDPA):
@staticmethod
def get_param_details(event):
input_dims = event['args']['Input Dims']
q_shape, k_shape, v_shape = input_dims[0], input_dims[1], input_dims[2]
q_idx, k_idx, v_idx = 0, 1, 2
q_shape, k_shape, v_shape = input_dims[q_idx], input_dims[k_idx], input_dims[v_idx]
strides = event['args']['Input Strides']
q_stride, k_stride, v_stride = tuple(strides[q_idx]), tuple(strides[k_idx]), tuple(strides[v_idx])
B, N_Q, H_Q, d_h = q_shape
assert k_shape == v_shape, f"Key and value shapes are different: {k_shape} != {v_shape}"
_, N_KV, H_KV, _ = input_dims[1]
dropout = float(event['args']['Concrete Inputs'][3])
causal = eval(event['args']['Concrete Inputs'][5])
return {"B": B, "N_Q": N_Q, "H_Q": H_Q, "N_KV": N_KV, "H_KV": H_KV, "d_h": d_h,
"q_stride": q_stride, "k_stride": k_stride, "v_stride": v_stride,
"dropout": dropout, "causal": causal, "flash_impl": True}

class flash_attention_backward(flash_attention):
Expand Down
5 changes: 5 additions & 0 deletions examples/custom_workflows/generate_perf_report_megatron_lm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,18 @@ def get_param_details(event):
break
assert q_idx is not None, "query index not found"
q_shape, k_shape, v_shape = input_dims[q_idx: q_idx+3]
strides = event['args']['Input Strides']
q_strides, k_strides, v_strides = strides[q_idx: q_idx+3]
# convert stride to tuple
q_strides, k_strides, v_strides = tuple(q_strides), tuple(k_strides), tuple(v_strides)
B, N_Q, H_Q, d_h = q_shape
assert k_shape == v_shape, f"Key and value shapes are different: {k_shape} != {v_shape}"
_, N_KV, H_KV, _ = k_shape
is_causal = True
dropout_p = 0.0
flash_impl = True
return {"B": B, "N_Q": N_Q, "H_Q": H_Q, "N_KV": N_KV, "H_KV": H_KV, "d_h": d_h,
"q_strides": q_strides, "k_strides": k_strides, "v_strides": v_strides,
"dropout": dropout_p, "causal": is_causal, "flash_impl": flash_impl}

def main():
Expand Down