Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new custom workflow for generating performance reports for Megatron LM, utilizing trace data and custom performance model adjustments.
- Introduces a new script for consolidating trace data and outputting Excel reports.
- Updates performance model mappings to include FusedAttnFunc for SDPA operations.
Comments suppressed due to low confidence (1)
examples/custom_workflows/generate_perf_report_megatron_lm.py:9
- [nitpick] Python class names should follow the CamelCase convention. Consider renaming 'transformer_engine_attention' to 'TransformerEngineAttention'.
class transformer_engine_attention(SDPA):
lauri9
pushed a commit
that referenced
this pull request
Jun 11, 2025
This PR introduces a new custom workflow for generating performance reports for Megatron LM, utilizing trace data and custom performance model adjustments. Introduces a new script for consolidating trace data and outputting Excel reports. Updates performance model mappings to include FusedAttnFunc for SDPA operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.