Skip to content

use correct dtype in cmd#141

Merged
ajassani merged 1 commit intomainfrom
fix/gemmologist_dtype
May 8, 2025
Merged

use correct dtype in cmd#141
ajassani merged 1 commit intomainfrom
fix/gemmologist_dtype

Conversation

@ajassani
Copy link
Copy Markdown
Collaborator

@ajassani ajassani commented May 8, 2025

No description provided.

@ajassani ajassani requested a review from Copilot May 8, 2025 13:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the command used to compute gemmologist metrics by incorporating the correct data type (dtype) and refactors related methods to return both the computation time and command details.

  • Adds the "--dtype" option to the gemmologist command.
  • Extends metric dictionaries in tree_perf.py to include the gemmologist command.
  • Refactors get_gemmologist_time to return a tuple containing both the computed time and the command string.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
TraceLens/TreePerf/tree_perf.py Adds gemmologist command metric to performance outputs
TraceLens/PerfModel/perf_model.py Refactors gemmologist time computation to include dtype and returns a tuple with command information
Comments suppressed due to low confidence (2)

TraceLens/PerfModel/perf_model.py:193

  • The error message could be more informative. Consider formatting the error details (including stdout and stderr) to help diagnose simulation failures more effectively.
raise AssertionError("Not able to simulate in gemmologist", cmd, stdout, stderr)

TraceLens/PerfModel/perf_model.py:161

  • The docstring for get_gemmologist_time should be updated to reflect that it now returns a tuple (gemmologist_time, gemmologist_cmd) rather than a single value, ensuring clarity for future maintainers.
def get_gemmologist_time(arch, M, N, K, dtype):

@ajassani ajassani merged commit 1d5357c into main May 8, 2025
@ajassani ajassani deleted the fix/gemmologist_dtype branch May 8, 2025 13:19
lauri9 pushed a commit that referenced this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants