Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the command used to compute gemmologist metrics by incorporating the correct data type (dtype) and refactors related methods to return both the computation time and command details.
- Adds the "--dtype" option to the gemmologist command.
- Extends metric dictionaries in tree_perf.py to include the gemmologist command.
- Refactors get_gemmologist_time to return a tuple containing both the computed time and the command string.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TraceLens/TreePerf/tree_perf.py | Adds gemmologist command metric to performance outputs |
| TraceLens/PerfModel/perf_model.py | Refactors gemmologist time computation to include dtype and returns a tuple with command information |
Comments suppressed due to low confidence (2)
TraceLens/PerfModel/perf_model.py:193
- The error message could be more informative. Consider formatting the error details (including stdout and stderr) to help diagnose simulation failures more effectively.
raise AssertionError("Not able to simulate in gemmologist", cmd, stdout, stderr)
TraceLens/PerfModel/perf_model.py:161
- The docstring for get_gemmologist_time should be updated to reflect that it now returns a tuple (gemmologist_time, gemmologist_cmd) rather than a single value, ensuring clarity for future maintainers.
def get_gemmologist_time(arch, M, N, K, dtype):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.