Conversation
There was a problem hiding this comment.
Pull request overview
Updates the AINIC bundle version used by the Docker build pipeline, aligning the AINIC-enabled image build with the new ainic_bundle_1.117.5-a-58 artifact.
Changes:
- Bump AINIC bundle tarball/directory references from
...a-56to...a-58in the AINIC Dockerfile. - Update the CI workflow to copy the
...a-58bundle before building the-ainicimage. - Comment out the Torch and JAX unit-test jobs in the CI workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/docker/Dockerfile.ainic | Updates bundle filename/directory to ainic_bundle_1.117.5-a-58 for the AINIC image build. |
| .github/workflows/ci.yaml | Copies the new bundle for the AINIC build and disables (comments out) Torch/JAX unit-test jobs. |
| # run-unittest-torch: | ||
| # env: | ||
| # PRIMUS_WORKDIR: /mnt/apps_proxy/tas/0_public/primus_ci/actions-runner-torch | ||
| # # PRIMUS_WORKDIR: /wekafs/primus-data/primus_safe_ci/torch | ||
| # needs: [code-lint] |
There was a problem hiding this comment.
The run-unittest-torch job definition was removed (now fully commented out), so this workflow no longer runs any unit tests (the only remaining job besides build-docker is code-lint). If the intent is to temporarily disable UTs, please gate it behind a condition/input (e.g., workflow_dispatch input or an env flag) and add an inline rationale + tracking issue; otherwise restore the job so PRs still get test signal.
| # run-unittest-jax: | ||
| # env: | ||
| # PRIMUS_WORKDIR: /wekafs/primus-data/primus_safe_ci/jax | ||
| # needs: [code-lint] | ||
| # runs-on: [primus-lm-cicd-jax-m42vb] |
There was a problem hiding this comment.
The run-unittest-jax job is also removed/commented out, which eliminates JAX test coverage from CI entirely. If this is intentional, add a clear comment explaining why and a plan/issue to re-enable; otherwise restore the job (or at least keep a minimal smoke/unit-test subset) to prevent regressions landing unnoticed.
| COPY ${AINIC_BUNDLE_PATH}/ainic_bundle_1.117.5-a-58.tar.gz ${WORKDIR} | ||
| RUN cd ${WORKDIR} && \ | ||
| echo "Building ainic bundle... current directory: ${WORKDIR}" && \ | ||
| tar zxf ainic_bundle_1.117.5-a-56.tar.gz && \ | ||
| cd ainic_bundle_1.117.5-a-56 && \ | ||
| tar zxf ainic_bundle_1.117.5-a-58.tar.gz && \ | ||
| cd ainic_bundle_1.117.5-a-58 && \ |
There was a problem hiding this comment.
The AINIC bundle tarball name is hardcoded here and duplicated in the workflow; even a small version bump requires editing multiple strings and is easy to mismatch. Consider parameterizing the bundle filename/version via a build-arg (e.g., AINIC_BUNDLE_TARBALL/AINIC_BUNDLE_DIR) and using that in COPY/extract/cd so the version is set in one place (the workflow) and passed into the Docker build.
| mkdir -p $GITHUB_WORKSPACE/.github/workflows/docker/ainic | ||
| cp /apps/tas/0_public/primus_docker_ci/ainic/ainic_bundle_1.117.5-a-56.tar.gz $GITHUB_WORKSPACE/.github/workflows/docker/ainic/ || { echo "Error: Failed to copy ainic bundle"; exit 1; } | ||
| # cp /apps/tas/0_public/primus_docker_ci/ainic/ainic_bundle_1.117.5-a-56.tar.gz $GITHUB_WORKSPACE/.github/workflows/docker/ainic/ || { echo "Error: Failed to copy ainic bundle"; exit 1; } | ||
| cp /apps/tas/0_public/primus_docker_ci/ainic/ainic_bundle_1.117.5-a-58.tar.gz $GITHUB_WORKSPACE/.github/workflows/docker/ainic/ || { echo "Error: Failed to copy ainic bundle"; exit 1; } |
There was a problem hiding this comment.
This step now has both a commented-out copy of the previous bundle and a new hardcoded bundle filename. To reduce churn and avoid stale comments, consider defining the bundle name once (e.g., in env:) and using it in the cp command, and remove the commented-out cp line once the migration is confirmed.
No description provided.