Remove modules irrelevant to afl-qemu-trace #64
Conversation
McSinyx
force-pushed
the
afl++-sans-system-modules
branch
from
c0235f8 to
9ca69f4
Compare
* dtc, roms/* and slirp are for system emulation * capstone is not utilized in fuzzing scenarios with AFL++ * meson >= 0.55.3 is available on all supported distro releases
McSinyx
force-pushed
the
afl++-sans-system-modules
branch
from
9ca69f4 to
07eb1a9
Compare
McSinyx
changed the title
|
Also I understand the intent this also creates problems. e.g. removing capstone removes the ability to debug assembly if weird problems happen |
|
How about the other submodules? I don't think AFL++ works with system emulation and the required meson version is no longer exotic. Capstone repository is not that heavy so bundling it in the source tree is reasonable, fetch-performance-wise, even though QEMU doesn't really modify it and most distributions do include and link it with vanilla QEMU. BTW is Capstone integration still works with QEMU for AFL++? |
|
I agree that a lot of those modules can be removed. some are obvious whereas for others I would be clueless if they are needed or not without investing time I do not have. if you can redo the the PR to remove only those that are obviously not needed for user-mode qemu then I will happily merge it. |
This helps majorly with fetching time for packaging downstream.