Skip to content

Add support to cookies #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 30, 2018
Merged

Add support to cookies #69

merged 9 commits into from
Apr 30, 2018

Conversation

JulioRamos0
Copy link
Contributor

Support to cookies Auth

Support to cookies Auth
@ADmad
Copy link
Owner

ADmad commented Apr 26, 2018

Why?

@JulioRamos0
Copy link
Contributor Author

For an apps without Js CoreClient

@ADmad
Copy link
Owner

ADmad commented Apr 27, 2018

What kind of apps are those and why can't they use headers or query string to pass the token?

@JulioRamos0
Copy link
Contributor Author

In my app is based on FormAuth, and the AuthHeader isn't easy way... the parameter is more dificult for the app will content many Urls so we will have add the parameter to every path... and the easily way is use cookies with the jwt token.

@ADmad
Copy link
Owner

ADmad commented Apr 27, 2018

Why does a web app need URLs which pass credentials for a stateless authenticator? If you can use cookies means you can use session so why not just use regular session based authentication which FormAuth provides?

@ADmad
Copy link
Owner

ADmad commented Apr 27, 2018

I still don't fully understand your use case but checking around the net a bit I see support for reading JWT from cookie is also a common thing. So I am okay with this.

Tests needed for the new feature.

@JulioRamos0
Copy link
Contributor Author

Tests was added

@ADmad ADmad closed this Apr 30, 2018
@ADmad ADmad reopened this Apr 30, 2018
@stickler-ci
Copy link
Contributor

I couldn't find a .stickler.yml file in this repository. I can make one for you, or you can create one by following the documentation.

@ADmad
Copy link
Owner

ADmad commented Apr 30, 2018

Looks good, just the coding standards errors need to be fixed.
https://travis-ci.org/ADmad/cakephp-jwt-auth/jobs/372918641#L583

@stickler-ci
Copy link
Contributor

I couldn't find a .stickler.yml file in this repository. I can make one for you, or you can create one by following the documentation.

@stickler-ci
Copy link
Contributor

I couldn't find a .stickler.yml file in this repository. I can make one for you, or you can create one by following the documentation.

@stickler-ci
Copy link
Contributor

I couldn't find a .stickler.yml file in this repository. I can make one for you, or you can create one by following the documentation.

@ADmad
Copy link
Owner

ADmad commented Apr 30, 2018

Revert the last commit. I have already added .stickler.yml to master. You just need to fix the errors reported on phpcs Travis build.

@ADmad ADmad merged commit c6db124 into ADmad:master Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants