-
Notifications
You must be signed in to change notification settings - Fork 44
Add support to cookies #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Support to cookies Auth
Why? |
For an apps without Js CoreClient |
What kind of apps are those and why can't they use headers or query string to pass the token? |
In my app is based on FormAuth, and the AuthHeader isn't easy way... the parameter is more dificult for the app will content many Urls so we will have add the parameter to every path... and the easily way is use cookies with the jwt token. |
Why does a web app need URLs which pass credentials for a stateless authenticator? If you can use cookies means you can use session so why not just use regular session based authentication which FormAuth provides? |
I still don't fully understand your use case but checking around the net a bit I see support for reading JWT from cookie is also a common thing. So I am okay with this. Tests needed for the new feature. |
Tests was added |
I couldn't find a |
Looks good, just the coding standards errors need to be fixed. |
I couldn't find a |
I couldn't find a |
I couldn't find a |
Adding .stickler.yml configuration file
Revert the last commit. I have already added .stickler.yml to master. You just need to fix the errors reported on phpcs Travis build. |
Support to cookies Auth