(Minor) Fix eventually statements #1835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the move to akka _typed_, we will be using more and more scalatest's `eventually` as a replacement for akka's `awaitCond` (which isn't available in `testkit.typed`). But there is a catch: - `awaitCond` expects a boolean - `eventually` expects a non-failure Which means that we must use `eventually(assert(cond))`, and not `eventually(cond)`.
t-bast
approved these changes
Jun 7, 2021
Member
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
Good catch, we need to get used to that change in behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the move to akka typed, we will be using more and more
scalatest's
eventuallyas a replacement for akka'sawaitCond(which isn't available in
testkit.typed).But there is a catch:
awaitCondexpects a booleaneventuallyexpects a non-failureWhich means that we must use
eventually(assert(cond)), and noteventually(cond).