Add support for dual db backend #1746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still use sqlite as the primary db, but all calls are replicated asynchronously on postgres. The goal is to prepare a smooth transition from sqlite to postgres on a production server. This is a very specific use case and most users shouldn't use it, which is why the new config `eclair.db.driver=dual` is not documented.
t-bast
reviewed
Jul 7, 2021
| case Success(res) => res | ||
| case Failure(t) => | ||
| logger.error("postgres error:\n", t) | ||
| throw t |
Member
There was a problem hiding this comment.
Do we really want to throw here?
Since Sqlite is our primary DB, shouldn't we just swallow errors since this dual mode is only meant to let us monitor how postgres behaves in practice? This way we're sure it doesn't impact the running node, and can be deployed on mainnet safely (hopefully?).
Member
Author
There was a problem hiding this comment.
It already works that way, because this is all within a future that we are not waiting on. We have to provide a return type or an exception, but the throw is effectively ignored.
t-bast
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still use sqlite as the primary db, but all calls are replicated
asynchronously on postgres.
The goal is to prepare a smooth transition from sqlite to postgres
on a production server. This is a very specific use case and most users
shouldn't use it, which is why the new config
eclair.db.driver=dualisnot documented.