Retrieve bitcoin's mempool-min-fee #1608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Retrieve the minimum fee required to enter our mempool * Add a metric to track this value * Remove fallback fee providers when Bitcoin Core is used * Add a metric to track feerate retrieval errors For fallback fee providers that don't have any mempool information, we default to the 1008 block target. It doesn't matter as these fee providers will not be used anyway.
Codecov Report
@@ Coverage Diff @@
## master #1608 +/- ##
==========================================
- Coverage 87.34% 86.65% -0.70%
==========================================
Files 146 146
Lines 11058 11084 +26
Branches 471 477 +6
==========================================
- Hits 9659 9605 -54
- Misses 1399 1479 +80
|
pm47
reviewed
Dec 7, 2020
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/fee/FeeProvider.scala
Show resolved
Hide resolved
pm47
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For fallback fee providers that don't have any mempool information, we default to the 1008 block target. It doesn't matter as these fee providers will not be used anyway.