Fix channelstats (for real?) #1470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The channelstats API only returns results for the *outgoing* channels used when relaying. We must also include the *incoming* channels, otherwise it looks like they're inactive which doesn't reflect their real usage. Fixes #1465
pm47
approved these changes
Jun 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
channelstatsAPI only returns results for the outgoing channels used when relaying.It is misleading for users that the incoming channels aren't included in that API's results: they may incorrectly conclude that the incoming channels have no activity and should be closed.
This PR raises a couple questions though:
channelstatsthe result would be twice the fees you really collected, which may be an issue.amountreported compared to before: I now only take into account the amount that goes through this channel whereas before we used the total payment amount. Which one do you think is better?Maybe those questions indicate that we should do more in-depth changes to that API, but now is probably not the right time for that.
Fixes #1465