MPP preimage received event #1445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows removing the use of the node-relayer as a passthrough for fulfills, it can now simply listen to this event. Long term, this could be sent to the event stream to share with more actors.
t-bast
force-pushed
the
mpp-preimage-event
branch
from
bcb6c98 to
b797405
Compare
pm47
reviewed
Jun 23, 2020
Member
pm47
left a comment
pm47
left a comment
There was a problem hiding this comment.
Just need to catch and ignore PreimageReceived in the payment initiator.
We want to avoid warnings for unhandled events.
Member
Author
|
Done in 81abeb5 |
pm47
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MultipartPaymentLifecycle FSM sends a message as soon as it receives the preimage.
This allows removing the use of the node-relayer as a passthrough for fulfills, it can now simply listen to this event.
Long term, this could be sent to the event stream to share with more actors.