Delegate client creation to a specialized actor #1400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm47
force-pushed
the
rework-reconnection
branch
from
012bf05 to
51c59e5
Compare
pm47
changed the title
t-bast
reviewed
Apr 30, 2020
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalStateSpec.scala
Outdated
Show resolved
Hide resolved
We can't use the built-in state listener because it returns only states, not data.
This allows decoupling the reconnection task from the actual client creation.
Co-Authored-By: Bastien Teinturier <[email protected]>
pm47
force-pushed
the
rework-reconnection
branch
from
9c6eed3 to
5212607
Compare
Member
Author
|
Rebased. |
t-bast
previously approved these changes
Apr 30, 2020
pm47
force-pushed
the
rework-reconnection
branch
from
5212607 to
d299472
Compare
t-bast
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows decoupling the reconnection task from the actual client
creation.
First 4 commits are the core of this PR. The rest is bugfix and somewhat unrelated improvements in tests. Maybe I should split this PR in two.