Gossip metrics #1372
Merged
Gossip metrics #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding metrics for channel queries and gossip KPIs.
pm47
reviewed
Apr 10, 2020
eclair-core/src/main/scala/fr/acinq/eclair/router/Monitoring.scala
Outdated
Show resolved
Hide resolved
pm47
reviewed
Apr 14, 2020
| val RouteLength = Kamon.histogram("router.find-route.length", "Path-finding result length") | ||
|
|
||
| val QueryChannelRangeBlocksCount = Kamon.histogram("router.gossip.query-channel-range.blocks-count", "Number of blocks requested in query-channel-range") | ||
| val QueryChannelRangeRepliesCount = Kamon.histogram("router.gossip.query-channel-range.replies-count", "Number of reply-channel-range replies sent") |
Member
There was a problem hiding this comment.
It's a bit strange that we have both QueryChannelRangeReplies* and ReplyChannelRange*
Member
Author
There was a problem hiding this comment.
Do you want to rename this one ReplyChannelRangeCount? It kinda loses the information that it's the number of replies generated by a single incoming query, but as long as the comment here explains it...
Member
There was a problem hiding this comment.
Sorry to not be helping much, I just feel that something is a bit awkward in the naming but have trouble coming up with something better.
Member
Author
There was a problem hiding this comment.
Once inside a dedicated object, I think it's better. See 3e5a7b0
eclair-core/src/main/scala/fr/acinq/eclair/router/Monitoring.scala
Outdated
Show resolved
Hide resolved
pm47
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding metrics for channel queries and gossip KPIs.
@sstone @pm47 this is a good opportunity to add other metrics/logs if there are things that you wanted to have while you were investigating an issue and were missing. Please let me know if I can add other metrics related to gossip, or logs that may be useful for eclair-mobile/phoenix.
Don't hesitate to bikeshed the naming too if you don't like it, it will be a bit painful to change metric names once we have graphs/alerts we rely on.