Bump github.com/gorilla/websocket from 1.5.0 to 1.5.1

[dependabot]

Bumps github.com/gorilla/websocket from 1.5.0 to 1.5.1.

Release notes

Sourced from github.com/gorilla/websocket's releases.

Release v1.5.1

What's Changed

• Add check for Sec-WebSocket-Key header by @​hirasawayuki in gorilla/websocket#752
• Changed the method name UnderlyingConn to NetConn by @​JWSong in gorilla/websocket#773
• remove all versions < 1.16 and add 1.18 by @​ChannyClaus in gorilla/websocket#793
• Check for and report bad protocol in TLSClientConfig.NextProtos by @​ChannyClaus in gorilla/websocket#788
• check err before GotConn for trace by @​junnplus in gorilla/websocket#798
• Update README.md by @​coreydaley in gorilla/websocket#839
• Correct way to save memory using write buffer pool and freeing net.http default buffers by @​FMLS in gorilla/websocket#761
• Update go version & add verification/testing tools by @​coreydaley in gorilla/websocket#840
• update golang.org/x/net by @​coreydaley in gorilla/websocket#856
• update GitHub workflows by @​coreydaley in gorilla/websocket#857

New Contributors

• @​hirasawayuki made their first contribution in gorilla/websocket#752
• @​JWSong made their first contribution in gorilla/websocket#773
• @​ChannyClaus made their first contribution in gorilla/websocket#793
• @​junnplus made their first contribution in gorilla/websocket#798
• @​coreydaley made their first contribution in gorilla/websocket#839
• @​FMLS made their first contribution in gorilla/websocket#761

Full Changelog: gorilla/websocket@v1.5.0...v1.5.1

Commits

• ac0789b update GitHub workflows (#857)
• 78c3487 update golang.org/x/net (#856)
• 666c197 Update go version & add verification/testing tools (#840)
• 8039329 Correct way to save memory using write buffer pool and freeing net.http defau...
• 8983b96 Merge pull request #839 from gorilla/coreydaley-patch-1
• 931041c Update README.md
• 76ecc29 archive mode
• af47554 check error before GotConn for trace
• bc7ce89 Check for and report bad protocol in TLSClientConfig.NextProtos (#788)
• 27d91a9 drop the versions of go that are no longer supported + add 1.18 to ci
• Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[StevenACoffman]

@telemenar @UnAfraid @vlad-tokarev @szgupta @zhixinwen Any of you websocket gqlgen contributors know why this upgrade is failing? I would appreciate someone taking a look! Thanks.

[UnAfraid]

@StevenACoffman I'll have a look at it

Edit: gorilla/websocket#877
Edit 2: https://github.com/gorilla/websocket/pull/840/files#diff-4f427d2b022907c552328e63f137561f6de92396d7a6e8f6c2ea1bcf0db52654L190-R197 this is the culprit, we are no longer getting net.ErrClosed, because all the errors are being hidden away...
Edit 3: gorilla/websocket#894 i've opened pull to fix the issue upstream

[StevenACoffman]

Thanks so much!

[StevenACoffman]

So gorilla merged @UnAfraid PR (thanks!), but I see a lot of people have had a lot of other problems with gorilla 1.5.1 release. Since I don't use websockets, I'm not clear if it is wise to update gqlgen's gorilla/websocket dependency to the current mainline commit or if we should wait until the 1.5.2 release. People can try it out with:

go mod edit -replace github.com/gorilla/websocket=github.com/gorilla/websocket@695e9095ce8736ac99c83939ca6b0fe93768f680

If the current 1.5.0 is working for folks, I'm ok with waiting until 1.5.2, but if 1.5.0 is breaking someone's production, I'm also ok with going forward.

I'm going to let the decision rest with gqlgen's Websocket Council of Wisdom™️ @telemenar @UnAfraid @vlad-tokarev @szgupta @zhixinwen

[StevenACoffman]

For anyone watching, the 1.5.1 release had a number of problems, which gqlgen contributors have been making patches on. We're going to ignore 1.5.1 and hope that 1.5.2 is in better shape.

[dependabot]

Looks like github.com/gorilla/websocket is no longer being updated by Dependabot, so this is no longer needed.

[StevenACoffman]

@dependabot ignore

[dependabot]

Sorry, the command you entered is not valid for this pull request. Please check the syntax and try again.

Valid commands:
For single dependency PRs, use commands like:
@dependabot ignore this major version
@dependabot ignore this minor version
@dependabot ignore this dependency