Skip to content

fix: remove breaking spaces exported desktop files#2051

Merged
dottorblaster merged 1 commit into89luca89:nextfrom
simon-wg:main
Apr 6, 2026
Merged

fix: remove breaking spaces exported desktop files#2051
dottorblaster merged 1 commit into89luca89:nextfrom
simon-wg:main

Conversation

@simon-wg
Copy link
Copy Markdown

@simon-wg simon-wg commented Apr 5, 2026

I noticed some issues when exporting vscode to my host.

Due to not having any of the rootful/enter_flags/sudo_prefix options set, the Exec command of the exported desktop file had too many spaces, not following standards, and causing bemenu to be unable to launch them.
The same issue was present for the extra_flags.

The solution was to use shell parameter expansion instead of just listing the parameters.

Examples before the fix:

  • Exporting an app.
    Exec=/usr/bin/distrobox-enter -n devel -- /usr/share/code/code %F
  • Generating desktop entry
    Exec=/usr/bin/distrobox enter devel

After fix:

  • Exporting an app.
    Exec=/usr/bin/distrobox-enter -n devel -- /usr/share/code/code %F
  • Generating desktop entry
    Exec=/usr/bin/distrobox enter devel

@dottorblaster
Copy link
Copy Markdown
Collaborator

Did you try replicating the behavior on the next branch? We gladly accept fixes there

@simon-wg
Copy link
Copy Markdown
Author

simon-wg commented Apr 5, 2026

Oh sorry, I didn't read the part about a complete rewrite in go.
I'm able to replicate the behavior on next as well, at least for exporting, so I'll rebase my changes to the script there!

Edit: Was able to replicate for generate-entry as well, so have ported that fix to go templates.

@simon-wg simon-wg changed the base branch from main to next April 5, 2026 17:10
Copy link
Copy Markdown
Collaborator

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@dottorblaster dottorblaster merged commit 74062ed into 89luca89:next Apr 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants