extract a template file #6
Conversation
|
Hi @andrewmd5 ! As the changes in this pull-request are the first step I took towards fulfilling the task in #4 ("How to build the project on a local Linux/Unix/etc. system") , I would appreciate reviewing and merging it. Thanks! Shabbath Shalom |
| ccflags='$ccflags -DBIG_TIME -DNO_MATHOMS -Wno-implicit-function-declaration -D_WASI_EMULATED_PROCESS_CLOCKS -lwasi-emulated-process-clocks -D_WASI_EMULATED_GETPID -lwasi-emulated-getpid -D_GNU_SOURCE -D_POSIX_C_SOURCE -Wno-null-pointer-arithmetic -D_WASI_EMULATED_SIGNAL -lwasi-emulated-signal -include /opt/wasi-sdk/share/wasi-sysroot/include/wasm32-wasi/fcntl.h -I[% github_workspace %]/stubs' | ||
| cppflags='-lm -Wno-implicit-function-declaration -DBIG_TIME -DNO_MATHOMS -D_WASI_EMULATED_PROCESS_CLOCKS -lwasi-emulated-process-clocks -D_WASI_EMULATED_GETPID -lwasi-emulated-getpid -D_GNU_SOURCE -D_POSIX_C_SOURCE -DSTANDARD_C -DPERL_USE_SAFE_PUTENV -D_WASI_EMULATED_SIGNAL -lwasi-emulated-signal -Wno-null-pointer-arithmetic -fno-strict-aliasing -pipe -fstack-protector-strong -include /opt/wasi-sdk/share/wasi-sysroot/include/wasm32-wasi/fcntl.h -I[% github_workspace %]/stubs' |
There was a problem hiding this comment.
The placeholder shouldn't be called github_workspace.
The default working directory on the runner for steps, and the default location of your repository when using the checkout action.
So perhaps project_directory?
(It'd probably make sense to pass this as $1, so that no templating is necessary?)
There was a problem hiding this comment.
Hi. Where do you see project_directory? Moreover, positional parameters ( $1 ) are less reliable, robust, and powerful than named template fields.
There was a problem hiding this comment.
project_directory is my suggestion, because that's what this path is.
positional parameters ( $1 ) are less reliable, robust, and powerful than named template fields.
The user will be forced to run an additional step to substitute variables to prepare the template for use (e.g. with envsubst), so I'm not sure that's worth it for a simple shell script.
Perhaps a good compromise is to just read a PROJECT_DIR env var directly from the script.
|
@andrewmd5 and all: ping |
A stepping stone in extracting a locally-runnable build program