Merged
Conversation
akostadinov
reviewed
Mar 2, 2023
akostadinov
reviewed
Mar 2, 2023
akostadinov
reviewed
Mar 2, 2023
| ``` | ||
|
|
||
| * **Macs with M1** also require de following: | ||
| * **Macs with M1** also require the following: |
Contributor
There was a problem hiding this comment.
will you include heare the instructions to install local-fastimage_resize?
#3065 (comment)
Contributor
Author
There was a problem hiding this comment.
Once the PR is verified and merged, yes
akostadinov
reviewed
Mar 2, 2023
akostadinov
previously approved these changes
Mar 2, 2023
Contributor
akostadinov
left a comment
There was a problem hiding this comment.
I added some comments. Since what you did is a clear improvement, if you don't want to deal with more changes, feel free to merge.
b372cf8 to
47cb876
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mysqlandpostgresqlas dependencies.