Skip to content
This repository was archived by the owner on Dec 12, 2024. It is now read-only.

feat: Update container base image #17

Merged
merged 3 commits into from
Sep 17, 2021
Merged

feat: Update container base image #17

merged 3 commits into from
Sep 17, 2021

Conversation

raelga
Copy link
Member

@raelga raelga commented Sep 17, 2021 •
edited
Loading

  • Replace base image with distroless/static: smaller and less prone to vulnerabilities
  • Enables using a non-docker container engine for building using the CONTAINER_ENGINE env var
  • Adds the OWNERs file for enabling Prow tide and approval plugins

/kind feature
/priority important-longterm
/assign

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/S Requires less than a day to complete the PR or the issue. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. labels Sep 17, 2021
@3scale-sre 3scale-sre deleted a comment from 3scale-robot Sep 17, 2021
@raelga
Copy link
Member Author

raelga commented Sep 17, 2021

/retitle feat: Update container base image

@3scale-robot 3scale-robot changed the title Feat/update container base image feat: Update container base image Sep 17, 2021
@raelga
Copy link
Member Author

raelga commented Sep 17, 2021

/cc @roivaz
/cc @slopezz

@slopezz
Copy link

slopezz commented Sep 17, 2021

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2021
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dcf2c805f5bf4b577febb57c91be75f988c677b2

@raelga
Copy link
Member Author

raelga commented Sep 17, 2021

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raelga
Copy link
Member Author

raelga commented Sep 17, 2021

PR manually merged as the OWNERs file it's going to be included with this PR.

@raelga raelga merged commit 9a31d03 into master Sep 17, 2021
@raelga raelga deleted the feat/update-container-base-image branch September 17, 2021 14:44
@raelga raelga added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slopezz slopezz Awaiting requested review from slopezz

1 more reviewer

@roivaz roivaz roivaz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@raelga raelga

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. size/S Requires less than a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raelga @slopezz @3scale-robot @roivaz