This repository was archived by the owner on Nov 14, 2025. It is now read-only.
Add SignedIn event accessors, to match docs #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [library readme](https://github.com/24Slides/laravel-saml2/blob/master/README.md) gives code examples of handling authentication events, including `$event->getAuth()` and `$event->getSame2User()`. Before this commit, that example code will fail because those accessors don't exist. This commit adds those accessors to match the readme code example.
Vinimaks
suggested changes
Mar 22, 2021
src/Events/SignedIn.php
Outdated
| public function getSaml2User(): Saml2User | ||
| { | ||
| $this->user = $user; | ||
| $this->auth = $auth; |
Contributor
Author
There was a problem hiding this comment.
Yep, sure is! 😞
Just noticed that after looking at the PR quality report.
Vinimaks
approved these changes
Mar 22, 2021
Contributor
Author
|
Thanks for the review @Vinimaks. @brezzhnev anything else needed before being able to merge? |
breart
approved these changes
Mar 30, 2021
Contributor
|
It's merged now. Thanks for you contribution :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library readme gives code examples of handling authentication events,
including
$event->getAuth()and$event->getSame2User().Before this commit, that example code will fail because those accessors don't exist.
This commit adds those accessors to match the readme code example.