-
Notifications
You must be signed in to change notification settings - Fork 45
feat: add gRPC Keyword monitor support #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0xfurai
commented
Jul 1, 2025
- Introduced a new gRPC Keyword monitor type in the healthcheck executor registry.
- Updated the monitor registry to include deserialization and component mapping for gRPC Keyword.
- Enhanced the general monitor types list to include gRPC Keyword with a description.
- Modified the monitor form context to support gRPC Keyword schema and form handling, ensuring comprehensive monitoring capabilities.
- Added necessary dependencies for gRPC and protobuf in the Go module.
- Introduced a new gRPC Keyword monitor type in the healthcheck executor registry. - Updated the monitor registry to include deserialization and component mapping for gRPC Keyword. - Enhanced the general monitor types list to include gRPC Keyword with a description. - Modified the monitor form context to support gRPC Keyword schema and form handling, ensuring comprehensive monitoring capabilities. - Added necessary dependencies for gRPC and protobuf in the Go module.
🚨 BugBot couldn't runSomething went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_1369ca72-1956-47be-91c6-9ebaa04a9847). |
|
bugbot run |
|
bugbot run |
- Introduced a new gRPC server in grpc-server.js, implementing Health and Test services with multiple methods for testing. - Updated package.json to include gRPC dependencies and added new scripts for starting the gRPC server. - Enhanced README.md with gRPC server usage instructions and testing scenarios. - Added temp-protos directory to .gitignore to exclude temporary proto files from version control.
…d web applications to streamline dependency management.
…in version control
- Added '@grpc/grpc-js' and '@grpc/proto-loader' with specified versions. - Included multiple protobuf-related packages to enhance gRPC functionality. - Updated dependencies for existing packages to ensure compatibility.
- Install pnpm globally and copy necessary workspace configuration files. - Update dependency installation to use monorepo root and ensure proper resolution. - Adjust source code copying and build commands for the web app. - Modify asset copying paths for Nginx serving.
- Adjusted build context and Dockerfile paths in docker-compose files for MongoDB, PostgreSQL, and SQLite services. - Enhanced healthcheck command formatting in PostgreSQL configuration. - Updated Dockerfile to include copying of patches directory for improved build process.
… naming conventions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: TLS Server Configuration Context Error
The TLS server configuration fails because the configureServices method is called with an incorrect context. The call method sets this to { server: tlsServer }, but configureServices expects this.healthProto and this.testProto to be present for service registration, which are missing from the provided context.
apps/fake-server/grpc-server.js#L325-L326
peekaping/apps/fake-server/grpc-server.js
Lines 325 to 326 in d394c2a
| const tlsServer = new grpc.Server(); | |
| this.configureServices.call({ server: tlsServer }); |
Was this report helpful? Give feedback by reacting with 👍 or 👎