Helm-Charts #236
Helm-Charts #236
Conversation
✅ Deploy Preview for peekaping ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for docspeekaping ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Feel free to let me know if i missed anything as this was written in about a day. |
|
I don't now how other people feel about it but I think the ability to provide the database credentials from a secret is a must for me. Nonetheless thank you for starting with this |
|
I’m very new with peekaping but from what I could tell the worker producer
ingester don’t have any open ports they work by communicating with the
database/redis. Web and api were the only 2 I needed to open ports for them
to work. I also did not see a way to add health checks to these services
as I didn’t see a health check endpoints in the documentation.
…On Tue, Nov 25, 2025 at 4:27 PM Adrian Stelter ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On charts/templates/ingress.yaml
<#236 (comment)>:
Shouldn't the file include all services per default with their respective
ports? As users not using istio can't take advantage of the istio
virtualservice
—
Reply to this email directly, view it on GitHub
<#236 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADAWJAQCKQEMEWM6M4ZIDZT36TCVTAVCNFSM6AAAAACNF7ULB6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKMBWHA4TOOJRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I fully agree with this - my goal was to give the community something to start with there is definitely a need to move credentials to secrets and my goal was just a round 1 iteration that the community can improve on. I will probably make some updates as I get time - this was just spare time work to get it up and running for us. As mentioned feel free to approve or use these as a starting point for a more hardened version. |
@zitrusgelb I've added the ability to read the config from either an existing secret in kubernetes, provide them directly in the values.yaml or a combination of both. |
|
I've updated the ingress to support both non istio routes as well as istio backend - I tested both ways and worked in my deployment using eks |
|
Nice, really appreciate your work. Though not a member of the project I think it helps a lot. I will give it a try next week. |
|
I tried it and it worked. Though I am probably gonna add a way to set the env variables directly in the |
|
Thanks for this contribution! This is huge! |
|
implements #221 |
3 participants
Here is my attempt at a basic helm chart based on my requirements - this has been tested working on EKS with redis/postgresql enabled in cluster. I have included istio and an ingress for what is working in our setup feel free to change or ask for me to remove