-
Notifications
You must be signed in to change notification settings - Fork 45
chore: update Makefile and add asdf configuration for Go environment #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
7b1f37c to
cb18e86
Compare
* Modify Makefile to use asdf for running Go commands * Add .asdfrc for asdf configuration * Create .tool-versions to specify Go version 1.24.1 * Update package.json to use asdf for development and build scripts
…mentation * Add .tool-versions file to specify Go, Node.js, and pnpm versions * Update Makefile to utilize new wrapper scripts for Go and pnpm commands * Introduce setup target in Makefile for automated environment setup with asdf * Revise development documentation to reflect new tool management options and installation instructions * Create wrapper scripts for Go and pnpm to ensure consistent tool usage
cb18e86 to
f79f146
Compare
0xfurai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution!
The docs and dev setup definitely need some love — 100%.
I still have a few doubts about asdf in general since I haven’t used it much. The idea of using it for a multi-language project is great, but when I tried installing it on Ubuntu, it turned out I needed Go to build it — which kind of makes the whole effort a bit ironic 😄.
What do you think about it? Maybe devcontainers is a better choice to go?
|
Good point! I am on Mac and installed asdf as multi runtime manager via brew. Feedback incorporated. |
* Change Node.js version from 22.0.0 to 20.18.0 (current LTS) in .tool-versions and server/.tool-versions * Update package.json to reflect the new Node.js version requirement * Revise development documentation to indicate the updated Node.js version
…pt and update Makefile * Remove deprecated go.sh and pnpm.sh scripts * Introduce tool.sh as a universal wrapper for executing commands with asdf or system binaries * Update Makefile to utilize tool.sh for running Go and pnpm commands * Revise development documentation to reflect changes in wrapper script usage
…entation * Introduce 'dev' target in Makefile to streamline starting the development environment * Update development documentation to recommend using 'make dev' for running the development stack
|
So asdf very popular and is mostly for dev env, its also optional so I happy to see it in project |
…ation * Introduce 'install' target in Makefile for streamlined dependency installation * Update development documentation to reflect new installation process and asdf integration * Provide troubleshooting tips for common asdf issues and manual tool installation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=======================================
Coverage 19.31% 19.31%
=======================================
Files 170 170
Lines 18144 18144
=======================================
Hits 3504 3504
Misses 14479 14479
Partials 161 161 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nstallation instructions
.tool-versionsto specify tool versions (Go 1.24.1, Node.js 22.0.0, pnpm 9.0.0)make setuptarget for automated development environment setupscripts/go.sh,scripts/pnpm.sh) that auto-detect asdf availabilityThis is purely optional.
asdfis a multiple runtime version manager that automatically manages tool versions. If asdf is not available, the project falls back to system-installed binaries. See https://asdf-vm.com/Usage:
make setup(one-time setup), then use commands normally