Skip to content

Conversation

@0xfurai
Copy link
Owner

@0xfurai 0xfurai commented Sep 28, 2025

Note

Update monitor now returns 404 when the target monitor does not exist, with repos propagating ErrMonitorNotFound and controller mapping it to HTTP 404.

  • Backend:
    • Error handling:
      • Add ErrMonitorNotFound in modules/monitor/errs.go.
      • Map repository not-found to HTTP 404 in monitor.controller.UpdateFull using errors.Is(err, ErrMonitorNotFound).
    • Repositories:
      • Mongo: UpdateFull returns ErrMonitorNotFound when FindByID yields no result; minor import updates.
      • SQL: UpdateFull checks RowsAffected; returns ErrMonitorNotFound when 0 rows affected.

Written by Cursor Bugbot for commit 7618a03. This will update automatically on new commits. Configure here.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 28, 2025

Deploying peekaping with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7618a03
Status: ✅  Deploy successful!
Preview URL: https://d7b70363.peekaping.pages.dev
Branch Preview URL: https://fix-update-monitor-200-if-mo.peekaping.pages.dev

View logs

@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.29%. Comparing base (a77456f) to head (7618a03).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rver/src/modules/monitor/monitor.sql.repository.go 0.00% 12 Missing ⚠️
...s/server/src/modules/monitor/monitor.controller.go 0.00% 4 Missing ⚠️
...er/src/modules/monitor/monitor.mongo.repository.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   19.31%   19.29%   -0.02%     
==========================================
  Files         170      170              
  Lines       18124    18141      +17     
==========================================
  Hits         3501     3501              
- Misses      14462    14479      +17     
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@0xfurai 0xfurai merged commit 3fab720 into main Sep 28, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants