feat: enhance management of custom docker images #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
praetoriansentry
approved these changes
Apr 29, 2024
praetoriansentry
pushed a commit
that referenced
this pull request
May 13, 2025
* chore: move `zkevm-contracts.Dockerfile` * feat: add zkevm-bridge-ui patch * ci: add cron job to build the zkevm-bridge-ui image * ci: add cron job to build zkevm-contracts images * ci: fix zkevm-contracts build * feat: add zkevm-bridge-ui Dockerfile * docs: remove zkevm-cache-contracts page * chore: clean up * doc: add docs to build images locally * test * fix: zkevm-bridge-ui job * ci: add concurency in ci * ci: same * test * fix: issue with zkevm-bridge-ui * test * chore: nit * docs: update README * docs: nit * ci: build images every week instead of every day * fix: push to docker hub in the meantime * chore: pull images from docker hub * fix: npm install issue * ci: fix hadolint in ci lint check * fix: network helper Dockerfile * fix: zkevm-contracts Dockerfile * fix: zkem-bridge-ui Dockerfile * fix: revert npm ci install fix * test * fix: npm install issues * chore: nit * chore: move workload to `docker/` * docs: explain how to build the workload img locally * ci: build workload img * chore: lint workload Dockerfile * chore: nit * chore: update zkevm-contracts tags * docs: update zkevm-contracts section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we manage three custom Docker images for deploying the CDK stack: one housing various zkevm contracts (each fork tagged separately), another adapting the bridge UI to accommodate relative URLs, and a third for applying workloads.
The aim is to:
=> For the moment, images are still hosted on the Docker Hub under my username. That's fine for now.
https://hub.docker.com/u/leovct
Other
npm installrandom fails with ECONNRESET and ETIMEDOUT by upgradingnpmto a version higher or equal to 10.5.1 (see the fix: fix: ensure maxSockets is respected npm/cli#7324)hadolintcheck in CI.Dockerfilefiles.References (if applicable)
https://polygon.atlassian.net/browse/DVT-1467
Test
I enabled the CI to run on this PR. I'll remove it once we've tested that we can build and successfully send images to our GCR.
Jobs are progressing and images are being built.