Define INPUT_LEN and adjust OUTPUT buffer size#69
Merged
0xAX merged 1 commit into0xAX:masterfrom Nov 19, 2025
Merged
Conversation
Added INPUT_LEN constant(no magic numbers) and updated OUTPUT buffer size. This was necessary because defining OUTPUT as ```assembly OUTPUT resb 1 ;; length of 1 byte ``` causes undefined behavior, and possibly a segfault.
Owner
|
@30be thank you! |
0xAX
added a commit
that referenced
this pull request
Dec 22, 2025
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
0xAX
added a commit
that referenced
this pull request
Dec 22, 2025
* asm-4: Update the stack example based on #69 Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com> * general: update contributors list Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com> * Remove not existed user from the contributors list Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com> --------- Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added INPUT_LEN constant(no magic numbers) and updated OUTPUT buffer size. This was necessary because defining OUTPUT as
causes undefined behavior, and possibly a segfault.