Skip to content

Conversation

@0x676e67
Copy link
Owner

close: #465

@0x676e67 0x676e67 added the C-feature Category: feature. This is requesting a new feature. label Dec 21, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @0x676e67, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive support for HTTP trailers within the rnet library's streaming response mechanism. By modifying the Streamer class and its underlying Rust implementation, consumers can now asynchronously iterate over response streams and receive not only body data chunks but also HTTP/1.1 or HTTP/2 trailers as HeaderMap objects. This enhancement provides greater flexibility for handling advanced HTTP features in streamed responses, directly addressing issue #465.

Highlights

  • HTTP Trailers Support: The Streamer class now supports HTTP trailers, allowing it to yield both body data (as bytes) and HTTP trailers (as HeaderMap objects) during asynchronous iteration.
  • Updated Type Signatures and Documentation: Python type hints for the Streamer's __anext__ and __next__ methods have been updated to reflect the new bytes | HeaderMap return type, and the documentation includes an example demonstrating how to handle both types of frames.
  • Internal Streaming Logic Refactor: The underlying Rust implementation of the Streamer has been refactored to directly manage the wreq::Response object, enabling it to extract and differentiate between body data and trailer frames more effectively.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for HTTP trailers in response streams, which is a valuable feature enhancement. The implementation correctly modifies the Streamer to handle both data chunks and trailer headers by processing the wreq::Response directly. The changes are consistently applied across the Rust implementation and the Python type stubs, including an updated example in the docstring. My review includes one suggestion for src/client/body/stream.rs to improve the robustness and clarity of the frame handling logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-feature Category: feature. This is requesting a new feature.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

HTTP Trailers

2 participants