Skip to content

Conversation

@0x676e67
Copy link
Owner

No description provided.

@0x676e67 0x676e67 requested a review from Copilot September 17, 2025 15:04
@0x676e67 0x676e67 changed the title feat(client): add verify_hostname option binding feat(client): add verify_hostname option binding Sep 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new verify_hostname option binding to the client configuration, allowing users to control whether hostname verification is performed during SSL/TLS connections.

  • Adds verify_hostname field to the Builder struct and related parameter extraction
  • Implements the hostname verification option in the client builder pattern
  • Updates Python type annotations to include the new verify_hostname parameter

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/client/mod.rs Adds verify_hostname field to Builder struct, parameter extraction, and client configuration
python/rnet/init.pyi Updates Python type annotations to include the new verify_hostname parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@0x676e67 0x676e67 merged commit 4691fba into main Sep 17, 2025
16 checks passed
@0x676e67 0x676e67 deleted the feat branch September 17, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants