Added Content-Disposition header to attachment download endpoint response headers#1032
Open
jissepo wants to merge 3 commits intozone-eu:masterfrom
Open
Added Content-Disposition header to attachment download endpoint response headers#1032jissepo wants to merge 3 commits intozone-eu:masterfrom
Content-Disposition header to attachment download endpoint response headers#1032jissepo wants to merge 3 commits intozone-eu:masterfrom
Conversation
andris9
reviewed
Mar 27, 2026
| } | ||
|
|
||
| if (attachmentFilename) { | ||
| headers['X-Filename'] = attachmentFilename; |
Member
There was a problem hiding this comment.
Why add non standard filename header? The correct place to include the filename is Content-Disposition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP Content-Disposition header indicates whether content should be displayed inline in the browser as a web page or part of a web page or downloaded as an attachment locally.
Since this is a
downloadendpoint, it makes sense for it to always also return the content disposition header, with disposition set toattachment.