[AI] agent node prompt tab new design + refactor#19012
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 11 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/twenty-front/src/modules/ai/utils/fieldsToSchema.ts">
<violation number="1" location="packages/twenty-front/src/modules/ai/utils/fieldsToSchema.ts:18">
P2: Use the trimmed name when building properties/required; otherwise names with leading/trailing spaces pass validation but produce schema keys with whitespace.</violation>
</file>
<file name="packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/components/WorkflowEditActionAiAgent.tsx">
<violation number="1" location="packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/components/WorkflowEditActionAiAgent.tsx:168">
P2: Guarding on `!workflowAiAgentActionAgent` blocks the entire panel when `agentId` is optional/absent, leaving the skeleton shown indefinitely. Only block when an agent is expected (e.g., when `agentId` is defined).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
...low/workflow-steps/workflow-actions/ai-agent-action/components/WorkflowEditActionAiAgent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
1 issue found across 5 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/twenty-front/src/modules/ai/hooks/useAiModelOptions.ts">
<violation number="1" location="packages/twenty-front/src/modules/ai/hooks/useAiModelOptions.ts:41">
P2: `model.modelId` is unsafely cast to generic `TValue`, which can infer to `null` and make `options` typed incorrectly versus runtime values.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
packages/twenty-front/src/modules/ai/hooks/useAiModelOptions.ts
Outdated
Show resolved
Hide resolved
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
...flow/workflow-steps/workflow-actions/ai-agent-action/components/WorkflowAiAgentPromptTab.tsx
Show resolved
Hide resolved
| }; | ||
|
|
||
| const StyledHandleContainer = styled.div` | ||
| position: absolute; |
There was a problem hiding this comment.
why this change?
This handle being the first child was causing a unwanted gap
before -
after -
...s/twenty-front/src/modules/workflow/workflow-variables/components/WorkflowVariablePicker.tsx
Show resolved
Hide resolved
...w/workflow-steps/workflow-actions/ai-agent-action/components/WorkflowOutputSchemaBuilder.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/components/WorkflowOutputSchemaBuilder.tsx">
<violation number="1" location="packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/ai-agent-action/components/WorkflowOutputSchemaBuilder.tsx:196">
P2: Clicking the remove icon now bubbles to the header click handler and also toggles the field. Stop propagation in the remove button handler to prevent unintended toggle state updates during deletion.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
...w/workflow-steps/workflow-actions/ai-agent-action/components/WorkflowOutputSchemaBuilder.tsx
Show resolved
Hide resolved
📊 API Changes ReportGraphQL Schema ChangesGraphQL Schema Changes[error] Error: Unable to read JSON file: /home/runner/work/twenty/twenty/main-schema-introspection.json: Not valid JSON content GraphQL Metadata Schema ChangesGraphQL Metadata Schema Changes[error] Error: Unable to read JSON file: /home/runner/work/twenty/twenty/main-metadata-schema-introspection.json: Not valid JSON content REST API Analysis ErrorError OutputREST Metadata API Analysis ErrorError Output |
| }; | ||
|
|
||
| @Command({ | ||
| name: 'upgrade:1-21:migrate-ai-agent-text-to-json-response-format', |
|
Thanks @ehconitin for your contribution! |
|
Hey @ehconitin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
3 participants
No description provided.