Skip to content

fix: expand kanban column drop zone to full height #18897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JASSBR wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: expand kanban column drop zone to full height #18897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1076073
fix: expand kanban column drop zone to full height
JASSBR Mar 24, 2026
497a699
fix: move droppable innerRef to StyledColumn for full-height drop zone
JASSBR Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ges/twenty-front/src/modules/object-record/record-board/components/RecordBoardColumns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { themeCssVariables } from 'twenty-ui/theme-constants';

const StyledColumnContainer = styled.div`
display: flex;
flex: 1;
& > *:not(:first-of-type) {
Comment on lines 8 to 12
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding flex: 1 here may not fully address the Kanban drop-zone issue described in #18842. The current @hello-pangea/dnd setup still renders droppableProvided.placeholder outside the element that receives droppableProvided.innerRef/droppableProps (see RecordBoardColumn.tsx vs RecordBoardColumnCardsContainer.tsx), which violates the library’s contract and can still lead to incorrect droppable measurements during drag. Consider fixing the placeholder placement (or an equivalent approach that keeps memoization) and/or verify with a repro that this CSS change alone resolves the drop behavior in scrolled/empty column areas.

Copilot uses AI. Check for mistakes.
border-left: 1px solid ${themeCssVariables.border.color.light};
Expand Down
12 changes: 6 additions & 6 deletions ...c/modules/object-record/record-board/record-board-column/components/RecordBoardColumn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,8 @@ import { isDefined } from 'twenty-shared/utils';
const StyledColumn = styled.div`
background-color: ${themeCssVariables.background.primary};
display: flex;
flex: 1;
flex-direction: column;
height: 100%;
max-width: 200px;
min-height: 100%;
min-width: 200px;
padding: ${themeCssVariables.spacing[2]};
padding-top: 0px;
Expand Down Expand Up @@ -63,14 +60,17 @@ export const RecordBoardColumn = ({
columnIndex: recordBoardColumnIndex,
}}
>
<Droppable droppableId={recordBoardColumnId}>
<Droppable droppableId={recordBoardColumnId} ignoreContainerClipping>
{(droppableProvided) => (
<StyledColumn>
<StyledColumn
ref={droppableProvided.innerRef}
// oxlint-disable-next-line react/jsx-props-no-spreading
{...droppableProvided.droppableProps}
>
<DragAndDropLibraryLegacyReRenderBreaker
memoizationId={recordBoardColumnId}
>
<RecordBoardColumnCardsContainer
droppableProvided={droppableProvided}
recordBoardColumnId={recordBoardColumnId}
/>
</DragAndDropLibraryLegacyReRenderBreaker>
Expand Down
10 changes: 2 additions & 8 deletions ...ct-record/record-board/record-board-column/components/RecordBoardColumnCardsContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Draggable, type DroppableProvided } from '@hello-pangea/dnd';
import { Draggable } from '@hello-pangea/dnd';
import { styled } from '@linaria/react';
import { useContext } from 'react';
import { themeCssVariables } from 'twenty-ui/theme-constants';
Expand All @@ -25,12 +25,10 @@ const StyledNewButtonContainer = styled.div`

type RecordBoardColumnCardsContainerProps = {
recordBoardColumnId: string;
droppableProvided: DroppableProvided;
};

export const RecordBoardColumnCardsContainer = ({
recordBoardColumnId,
droppableProvided,
}: RecordBoardColumnCardsContainerProps) => {
const { columnDefinition } = useContext(RecordBoardColumnContext);

Expand All @@ -45,11 +43,7 @@ export const RecordBoardColumnCardsContainer = ({
);

return (
<StyledColumnCardsContainer
ref={droppableProvided?.innerRef}
// oxlint-disable-next-line react/jsx-props-no-spreading
{...droppableProvided?.droppableProps}
>
<StyledColumnCardsContainer>
{recordIndexRecordIdsByGroup.map((recordId, index) => (
<RecordBoardCardDraggableContainer
key={recordId}
Expand Down
Loading