Skip to content

[Shogi] Update the explanation of the action space in the document.#1304

Open
KazukiOhta wants to merge 1 commit intosotetsuk:mainfrom
KazukiOhta:patch-3
Open

[Shogi] Update the explanation of the action space in the document.#1304
KazukiOhta wants to merge 1 commit intosotetsuk:mainfrom
KazukiOhta:patch-3

Conversation

@KazukiOhta
Copy link
Contributor

素晴らしいライブラリをご開発いただき、ありがとうございます。いつも楽しんで使わせていただいております。

提案

以下の通り、shogi ドキュメントの action の direction の説明を、「direction from which the piece moves and」から「direction to which the piece moves and」に変更することを提案します。

変更前

There are `2187 = 81 x 27` distinct actions.
The action can be decomposed into 

- `direction` from which the piece moves and
- `destination` to which the piece moves

変更後

There are `2187 = 81 x 27` distinct actions.
The action can be decomposed into 

- `direction` to which the piece moves and
- `destination` to which the piece moves

理由

例えば7六歩は行動番号では59であり、これは

  • direction: 0 (Up)
  • destination: 53 (7六の地点)

に対応します。この場合、歩は上に向かって進む(上から来るわけではない)ので、「to which」の方が直感的かと思い、以上の変更を提案いたします。

@KazukiOhta KazukiOhta changed the title [Shogi] Update the document. [Shogi] Update the explanation of direction in the document. Mar 13, 2025
@KazukiOhta KazukiOhta changed the title [Shogi] Update the explanation of direction in the document. [Shogi] Update the explanation of the action space in the document. Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant