fix: advertise fido2-vault-credentials in /api/config for extension passkey UX#160
Closed
fix: advertise fido2-vault-credentials in /api/config for extension passkey UX#160
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
nodewarden | ba990e1 | Mar 31 2026, 02:30 PM |
There was a problem hiding this comment.
Pull request overview
This PR updates the public /api/config (and /config) response to advertise server support for passkey-related vault functionality so Bitwarden browser extensions can enable their passkey UX instead of falling back to native/system prompts.
Changes:
- Adds
experimentalClientFeatureFlags: ['fido2-vault-credentials']to the config payload. - Enables
'fido2-vault-credentials': trueinfeatureStatesand documents why it’s exposed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+105
to
+113
| experimentalClientFeatureFlags: ['fido2-vault-credentials'], | ||
| _icon_service_url: buildIconServiceTemplate(origin), | ||
| _icon_service_csp: buildIconServiceCsp(origin), | ||
| featureStates: { | ||
| 'duo-redirect': true, | ||
| 'email-verification': true, | ||
| // Browser extensions only enable passkey vault storage/login UX when this | ||
| // server capability flag is exposed in /api/config. | ||
| 'fido2-vault-credentials': true, |
There was a problem hiding this comment.
The string literal 'fido2-vault-credentials' is duplicated in both experimentalClientFeatureFlags and featureStates. Consider defining a single constant (or deriving one from the other) so the flag name can’t drift if it ever changes/expands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
experimentalClientFeatureFlags: ['fido2-vault-credentials']and enable'fido2-vault-credentials': trueinsidefeatureStatesin the/api/configresponse implemented insrc/router-public.ts.Testing
npm run buildto build the web client and it completed successfully.npx tsc -p tsconfig.json --noEmitfor TypeScript checks and it completed successfully.Codex Task