fix PhiloGL.Program.fromShaderIds #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit d8a63a4 introduced a bug which broke fromShaderIds. This is specifically here: senchalabs@d8a63a4#diff-9589e3a0cc72e26a4814bc9ef05aa2d4R301 fromShaderIds is supposed to return a Program, but instead this function is delegating to onSuccess. But the arguments/options never allow an onSuccess to be specified. This patch removes that onSuccess call and just returns the Program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d8a63a4 introduced a bug which
broke fromShaderIds. This is specifically here:
d8a63a4#diff-9589e3a0cc72e26a4814bc9ef05aa2d4R301
fromShaderIds is supposed to return a Program, but instead this function is
delegating to onSuccess. But the arguments/options never allow an onSuccess
to be specified.
This patch removes that onSuccess call and just returns the Program.