Open
Conversation
3 tasks
vzhestkov
force-pushed
the
allow-ssh-users-with-backslash
branch
from
e0a9183 to
7ee0e05
Compare
vzhestkov
force-pushed
the
allow-ssh-users-with-backslash
branch
from
7ee0e05 to
95f5e8c
Compare
vzhestkov
force-pushed
the
allow-ssh-users-with-backslash
branch
from
95f5e8c to
7230e86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In case of using AD authentication on the client for the users, it's possible to use
user@domainwithsalt-ssh, but the other valid notationdomain\userdoesn't work as producing brokenthin_dirpath and user value is passing tosshthe wrong way with improper quoting.What issues does this PR fix or reference?
Tracks: https://github.com/SUSE/spacewalk/issues/29164
Previous Behavior
salt-ssh was failing with imporper calculation of target directory or either improper passing the username to ssh/scp commands used internally requiring extra quoting for the username (with extra quoting it was working fine to connect to remote system but was failing with directory path calculation)
New Behavior
salt-ssh is able to work properly with DOMAIN\USER notation of the username.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No