Make _auth calls visible with master stats#67746
Open
vzhestkov wants to merge 3 commits intosaltstack:masterfrom
Open
Make _auth calls visible with master stats#67746vzhestkov wants to merge 3 commits intosaltstack:masterfrom
_auth calls visible with master stats#67746vzhestkov wants to merge 3 commits intosaltstack:masterfrom
Conversation
vzhestkov
force-pushed
the
add-_auth-to-master-stats
branch
4 times, most recently
from
804f766 to
eb6b2a9
Compare
3 tasks
vzhestkov
force-pushed
the
add-_auth-to-master-stats
branch
from
eb6b2a9 to
fb164d5
Compare
twangboy
previously approved these changes
Jul 1, 2025
Contributor
|
Once the master branch is passing nightlies, please rebase and address the merge conflicts |
Contributor
|
Would you mind rebasing? |
vzhestkov
force-pushed
the
add-_auth-to-master-stats
branch
from
7cd8b23 to
93f75af
Compare
Contributor
|
Please resolve conflicts |
vzhestkov
force-pushed
the
add-_auth-to-master-stats
branch
from
93f75af to
c4a57d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In case of turning off publishing auth events with
auth_events: Falsewhile having logging level set toWARNINGthere is no any way to figure out the amount of processed authentication events, these types of events in huge amount can be only noiticed with indirect way by high CPU usage by the workers.This change is adding
_authcalls to the master stats, so it makes troubleshooting easier with no increasing the logging level.Previous Behavior
No
_authcalls present in master statsNew Behavior
_authcalls are published with master statsMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.