Add unique_id to entity data (fix #1005)#1072
Open
elijahr wants to merge 4 commits intosabeechen:devfrom
Open
Conversation
Author
|
😆 Silly me, I didn't read the CONTRIBUTING.md before submitting my pull request. I have updated the base branch to dev per instructions. I haven't been able to figure out how to test these changes, but hopefully the unit tests are sufficient. Anyways, thanks for making this great add-on! |
|
See #579 and my latest comment there. Sadly your changes did not work because the REST api simply will not accept unique_id |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My dashboard has this and it won't go away:
When I try to go to the settings for the entity to hide it, I encounter this message:
I have not been able to test these changes, but I have updated the unit tests.
Reference: