Skip to content

Add input range to AUX channels#48

Merged
anjaldoshi merged 4 commits into
mainfrom
add-input-range
Nov 15, 2025
Merged

Add input range to AUX channels#48
anjaldoshi merged 4 commits into
mainfrom
add-input-range

Conversation

@bparks13

@bparks13 bparks13 commented Nov 5, 2025

Copy link
Copy Markdown
Member

The current range is +/- 100 m/s^2, which might be too large of a range to be useful. After testing, we can see if we should decrease this range.

@bparks13 bparks13 self-assigned this Nov 5, 2025
@bparks13

bparks13 commented Nov 5, 2025

Copy link
Copy Markdown
Member Author

I saw that the actions are failing because the semantic version was not increased. Is this update considered a patch or a minor version increase?

@jsiegle

jsiegle commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Probably just a patch

@anjaldoshi

Copy link
Copy Markdown
Contributor

The IMU channels on the 3rd Gen Acquisition Board also require their input ranges to be specified, similar to the ONIX Source plugin.

https://github.com/open-ephys-plugins/acquisition-board/blob/main/Source/devices/oni/AcqBoardONI.cpp#L230-L375

@bparks13

Copy link
Copy Markdown
Member Author

@anjaldoshi @jsiegle

I'm testing this PR with the development branch of the main GUI to test the units and custom ranges, and I have a couple comments:

  • In the ONIX source plugin, the memory range was left as [0, 100], which then only displays from -50 to 50 in the LFP viewer, which I believe is intentional but can be slightly misleading if anyone in the future is trying to set a custom range. I've updated it here to be +/-100% to be symmetrical, and I will update it in the ONIX source plugin too
  • Units: In a previous update, we set the units of the channels, but now that they are being displayed we might want to revisit the units (see image below). Specifically, for the Euler angles and the temperature, we spell out the units (e.g., "Degrees" and "Celsius", respectively), but we might want to use the symbols (e.g., "°" and "°C") if the display/saving can handle them, otherwise they get cut off.
    • Related is the units for Quaternion/calibration data. I explicitly set them as "u" for unitless, but should we exclude them so that there isn't anything printed there? Which one is more cohesive and understandable?
image

@anjaldoshi

anjaldoshi commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

Thanks for updating the memory usage input range. I totally forgot about that.

About the units: using just “°” for Euler angles may look a bit odd since it can be mistaken for a tiny circle. “Deg” feels a bit clearer. For temperature, “°C” works great. And for unitless channels, make sure to explicitly set the units to an empty string otherwise the GUI will default AUX channels to “mV,” which can be confusing.

@bparks13

Copy link
Copy Markdown
Member Author

@anjaldoshi I've updated based on your recommendation. I had to write String::fromUTF8 ("\xc2\xb0") + String("C") to get the degree symbol to show up correctly, let me know if there is a better way to do it!

@anjaldoshi anjaldoshi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anjaldoshi anjaldoshi merged commit 202c30a into main Nov 15, 2025
9 checks passed
@bparks13 bparks13 deleted the add-input-range branch January 13, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants