Skip to content

Fix index decoding in aux channels#47

Merged
anjaldoshi merged 5 commits into
mainfrom
aux-indexes
Jul 18, 2025
Merged

Fix index decoding in aux channels#47
anjaldoshi merged 5 commits into
mainfrom
aux-indexes

Conversation

@aacuevas

Copy link
Copy Markdown
Collaborator

Fixed issue that was causing aux channels become mangled

As a question, in here:

Should be use this monolithic counter, or the Rhythm sample counter?

@jsiegle

jsiegle commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Rhythm sample counter may be better, but we should test that more extensively before making that change.

Can you also bump the plugin version number to 1.1.3?

@bparks13

bparks13 commented Jul 17, 2025

Copy link
Copy Markdown
Member

I bumped the version number so that the actions pass.

I also took the opportunity to change the log from error to console when no Opal Kelly board is found.

Question; there is an outstanding issue we've discussed which is to give a pop-up indicating if the board firmware version is too old. What is the cutoff for that version? Is it any versions 0.x that need to be updated? That might be a good addition to add in to this patch version.

@bparks13 bparks13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with one 64 channel headstage, and it correctly streams AUX data.

@jsiegle

jsiegle commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

@aacuevas what is the minimum gateware version needed for this plugin? It looks like 1.5.3 is the latest. Should we just say 1.5.x to be on the safe side?

bparks13 and others added 2 commits July 17, 2025 16:59
- This will also catch version 1.0 of the gateware, as it reports the major version as 0 and the minor version as 1, but this is okay as users should still update to a higher version to make use of all the available features
@anjaldoshi anjaldoshi merged commit 4e4f00f into main Jul 18, 2025
9 checks passed
@bparks13 bparks13 deleted the aux-indexes branch July 18, 2025 13:50
@aacuevas

Copy link
Copy Markdown
Collaborator Author

Rhythm sample counter may be better, but we should test that more extensively before making that change.

Can you also bump the plugin version number to 1.1.3?

@jsiegle sorry, my email seems to have stopped working yesterday and I got all the notifications today.

Rhythm sample counter is what we used to use before the advent of real time timestamps, so I imagine they should be safe. But it does not hurt to check just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants