Fix index decoding in aux channels#47
Conversation
|
Rhythm sample counter may be better, but we should test that more extensively before making that change. Can you also bump the plugin version number to 1.1.3? |
|
I bumped the version number so that the actions pass. I also took the opportunity to change the log from error to console when no Opal Kelly board is found. Question; there is an outstanding issue we've discussed which is to give a pop-up indicating if the board firmware version is too old. What is the cutoff for that version? Is it any versions 0.x that need to be updated? That might be a good addition to add in to this patch version. |
bparks13
left a comment
There was a problem hiding this comment.
Tested this with one 64 channel headstage, and it correctly streams AUX data.
|
@aacuevas what is the minimum gateware version needed for this plugin? It looks like 1.5.3 is the latest. Should we just say 1.5.x to be on the safe side? |
- This will also catch version 1.0 of the gateware, as it reports the major version as 0 and the minor version as 1, but this is okay as users should still update to a higher version to make use of all the available features
@jsiegle sorry, my email seems to have stopped working yesterday and I got all the notifications today. Rhythm sample counter is what we used to use before the advent of real time timestamps, so I imagine they should be safe. But it does not hurt to check just in case. |
Fixed issue that was causing aux channels become mangled
As a question, in here:
acquisition-board/Source/devices/oni/AcqBoardONI.cpp
Line 1777 in d71507a
Should be use this monolithic counter, or the Rhythm sample counter?