fix: hardcoded paths, import check, UTC datetime#99
Open
yetval wants to merge 1 commit intomvanhorn:mainfrom
Open
fix: hardcoded paths, import check, UTC datetime#99yetval wants to merge 1 commit intomvanhorn:mainfrom
yetval wants to merge 1 commit intomvanhorn:mainfrom
Conversation
thakoreh
added a commit
to thakoreh/last30days-skill
that referenced
this pull request
Mar 26, 2026
…vanhorn#98, mvanhorn#99 - mvanhorn#93: Catch FuturesTimeoutError alongside TimeoutError for Python <3.11 compat - mvanhorn#94: Use UTC-aware datetime in websearch.py date calculations - mvanhorn#95: Parse 'N months ago' date format in brave_search.py - mvanhorn#96: Extend sync.sh import verification to cover all 34 lib modules - mvanhorn#98: Replace hardcoded developer paths in test-v1-vs-v2.sh with variables - mvanhorn#99: No hardcoded paths found in last30days.py (uses SCRIPT_DIR); UTC already used
Owner
|
Thanks for the PR. Hardcoded paths and UTC datetime are real issues. Can't commit to merging right now - the v3.0 refactor is changing the module structure - but I'll consider it once things settle. |
yetval
force-pushed
the
fix/hardcoded-paths-issue-98
branch
from
f3becc7 to
c1feb7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed three low-severity bugs:
/Users/mvanhorn/...paths intest-v1-vs-v2.shwith auto-detected values viagit rev-parseandcommand -v claude, with env var overridessync.shimport verification to dynamically check all modules inlib/instead of just 4websearch.pyto usedatetime.now(timezone.utc)instead of naive local timeCloses #94, #96, #98