Skip to content

Normalize Reddit subreddit names before rendering#111

Open
LittleChenLiya wants to merge 1 commit intomvanhorn:mainfrom
LittleChenLiya:codex/fix-reddit-subreddit-format
Open

Normalize Reddit subreddit names before rendering#111
LittleChenLiya wants to merge 1 commit intomvanhorn:mainfrom
LittleChenLiya:codex/fix-reddit-subreddit-format

Conversation

@LittleChenLiya
Copy link
Copy Markdown

Summary

This fixes a Reddit formatting bug where subreddit values can show up as object/dict strings in the rendered output instead of clean subreddit names.

For example, instead of rendering something like r/openclaw, the output could render r/{'id': 't5_...', 'name': 'openclaw', ...} when the upstream Reddit result returned a structured subreddit object.

What changed

  • Normalize Reddit subreddit values to a clean subreddit name before rendering
  • Handle both string and dict/object-shaped subreddit values
  • Apply the normalization across the Reddit search/parse/normalize path so downstream rendering and entity extraction stay consistent

Why

Issue #100 mentions cases where subreddit names are rendered incorrectly in the output. This PR fixes that user-visible formatting bug directly.

@LittleChenLiya
Copy link
Copy Markdown
Author

Hi @mvanhorn,
Sorry to disturb you.
I was just wondering if you might have time to take a quick look at this PR when you're available.
No rush at all. Thank you very much!

@mvanhorn
Copy link
Copy Markdown
Owner

Hey @LittleChenLiya, sorry for the delayed response - I see you've been busy and I appreciate the polite ping. The subreddit normalization here, the YouTube auto-caption warnings in #107, and the Windows timeout issue you flagged in #110 are all good catches.

I want to be upfront - we're deep in a v3.0 refactor that's rewriting most of the pipeline these PRs touch. I can't commit to merging any of these right now because the merge conflicts are going to be significant once 3.0 lands. I promise I'll come back and consider each one in the context of the new architecture.

It's been a crazy few days - we hit #1 trending on GitHub for three straight days, which is why there's such a wave of contributions and such a backlog. I really appreciate your patience and the quality of your work. Will be back once 3.0 settles.

@LittleChenLiya
Copy link
Copy Markdown
Author

嘿,抱歉回复晚了——我看到你最近很忙,也很感谢你的礼貌回复。这里的子版块规范化、#107 里的 YouTube 自动字幕警告,以及你在 #110 标记的 Windows 超时问题,都是很好的发现。

我想坦白说——我们正深入进行v3.0重构,正在重写这些PR接触的大部分流程。我现在还不能决定合并这些,因为3.0上线后合并冲突会很严重。我保证以后会在新架构的背景下仔细考虑每一个。

这几天真是疯狂——我们在GitHub上连续三天进入#1热搜,这也是为什么贡献浪潮涌现,积压了这么多。我非常感谢你的耐心和作品质量。等3.0稳定后我会回来。

@mvanhorn 好呀!也许等你们3.0版本上线以后,我还可以基于新版本重写这部分内容——我很乐意

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants