Skip to content

upcoming: [DPS-41826] - add newFeature chip to render conditionally#13554

Open
santoshp210-akamai wants to merge 2 commits intolinode:developfrom
santoshp210-akamai:feature/addFeatureChip_to_alerts
Open

upcoming: [DPS-41826] - add newFeature chip to render conditionally#13554
santoshp210-akamai wants to merge 2 commits intolinode:developfrom
santoshp210-akamai:feature/addFeatureChip_to_alerts

Conversation

@santoshp210-akamai
Copy link
Copy Markdown
Contributor

Description 📝

Add newFeature chip to render conditionally.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Add getFeatureFlagChip to the AlertReusableComponent to be consistent wit the Linode-edit flow (V1, V2)
  • Add condition to render isNew when new is enabled and beta is disabled
  • Add UTs

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Include a screenshot <img src="" /> or video <video src="" /> of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 For changes requiring multiple steps to validate, prefer a video for clarity.

Component When Beta is enabled and new is enabled When Beta is enabled and new is disabled When Beta is disabled and new is enabled
Primary Nav component image image image
AlertResuableComponent image image image

How to test 🧪

Prerequisites

(How to setup test environment)

  • Point the localhost to Devcloud environment
  • Enable and disable the new, beta boolean in Cloudpulse Alerting (aclpAlerting)

Reproduction steps

(How to reproduce the issue, if applicable)

  • ...
  • ...

Verification steps

(How to verify changes)

  • ...
  • ...
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@linode-gh-bot
Copy link
Copy Markdown
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing901 Passing11 Skipped37m 35s

Details

Failing Tests
SpecTest
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » can update bucket access

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

2 participants