fix: Reference to undefined setting: scriptedKeepTempDirectory#1053
Open
EndlessLucky wants to merge 12 commits intofoundweekends:developfrom
Open
fix: Reference to undefined setting: scriptedKeepTempDirectory#1053EndlessLucky wants to merge 12 commits intofoundweekends:developfrom
EndlessLucky wants to merge 12 commits intofoundweekends:developfrom
Conversation
Author
|
@eed3si9n Would you please review this PR? Thanks. |
eed3si9n
requested changes
Mar 4, 2026
Member
eed3si9n
left a comment
eed3si9n
left a comment
There was a problem hiding this comment.
I think
override val requires = sbt.plugins.JvmPlugin && sbt.ScriptedPluginwas the right approach
xuwei-k
changed the title
Author
|
@eed3si9n Would you please review this PR? Thanks. |
Author
|
@eed3si9n Is there any way to run these checks automatically once push commits? |
Author
|
@eed3si9n Is there any way to automate this workflow? |
Member
|
You can enable GitHub Actions on your forked repo or run the commands locally. First time pull requests are gated for security reasons. |
Author
|
I enabled it and it was run successfully before. But it doesn't work now. |
Author
|
@eed3si9n My forked repo's workflow was run successfully and this workflow is not started. Would you please take a look? |
xuwei-k
requested changes
Mar 25, 2026
| .jvmPlatform( | ||
| scalaVersions = Seq(scala3), | ||
| // sbt 2.x scripted-sbt resolution does not match sbt 1.x fixture projects; giter8 scripted is exercised on 2.12. | ||
| settings = Seq( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[2.x] fix: initialize ScriptedPlugin settings for sbt 2 RC9
Problem
Using sbt-giter8 with sbt.version=2.0.0-RC9 fails during load with:
Reference to undefined setting: scriptedKeepTempDirectory from scripted.
The plugin was wiring ScriptedPlugin.projectSettings manually, which leaves scripted settings initialization inconsistent on sbt 2 RC9.
Solution
Require sbt.ScriptedPlugin directly in Giter8Plugin so scripted settings are initialized via plugin requirements, and remove the manual ScriptedPlugin.projectSettings ++ merge.
Also update the sbt 2 cross-build target from 2.0.0-RC8 to 2.0.0-RC9 in build.sbt.