fix: resolve relative_to() ValueError on Windows when experiment dir is outside cwd#86
Open
YihanJIANG-lab wants to merge 1 commit intoSakanaAI:mainfrom
Open
Conversation
…is outside cwd On Windows, when the experiment directory is not a subdirectory of the current working directory (e.g., experiments/ vs AI-Scientist-v2/), Path.relative_to() raises ValueError. This causes journal serialization to crash even after a successful experiment run. Add _safe_relpath() helper that tries relative_to() first, then falls back to os.path.relpath(). Replace all 3 occurrences of .relative_to(os.getcwd()) in Node.to_json() with this safe helper. Fixes crash on Windows when running experiments in a directory structure where the experiment output dir is not a subpath of cwd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
Path.relative_to(os.getcwd())raisesValueErrorwhen the experiment directory is on a different drive or not under the current working directory. This replaces the strict call with a_safe_relpath()helper that falls back toos.path.relpath()and ultimately to the absolute path.