fix: pass rope_scaling=None for Qwen3 to avoid unhashable dict error#198
Open
CruxZhou wants to merge 1 commit into
Open
fix: pass rope_scaling=None for Qwen3 to avoid unhashable dict error#198CruxZhou wants to merge 1 commit into
CruxZhou wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a runtime error when loading Qwen3 models with newer versions of transformers(>5).
Problem
Qwen3Attention forwards config.rope_scaling into get_rope(...), but get_rope() does not currently implement RoPE scaling and assumes rope_scaling is None.
In newer transformers versions, config.rope_scaling may be parsed as a dict, which causes:
TypeError: unhashable type: 'dict'
because get_rope() is cached with lru_cache.
Fix
Pass rope_scaling=None explicitly in Qwen3Attention.
This keeps behavior aligned with the current implementation status and avoids the runtime error without changing existing RoPE logic.
Fixes #189